[Lldb-commits] [PATCH] D18381: Decouple ClangASTContext from DWARF

[Greg Clayton via lldb-commits]

clayborg added a comment.

No. Keep GetDWARFParser() on TypeSystem and all that code as is. You shouldn't need to add GetPDBParser() to TypeSystem as you should get a type system for language from within your SymbolFilePDB (with a language like C or C++) and then make a PDBParser with a reference to your ClangASTContext. So no one else should need to know. The main reason we get the DWARF parser from the type system is we have 2 ways to have DWARF with references to other DWARF files like the MacOSX DWARF in .o files with a debug map where each .o file is a separate SymbolFileDWARF, but they all need to use the common ClangASTContext, so we can't just have each SymbolFileDWARF create its own DWARFASTParser, we need to share a single one. You shouldn't have this problem with PDB since everything is within a single file. We will need to make sure the MacOSX test suite still runs clean with any changes.


http://reviews.llvm.org/D18381