[Lldb-commits] [lldb] r263520 - Add some test coverage for the changes in alias help

[Enrico Granata via lldb-commits]

> On Mar 18, 2016, at 2:45 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Hi Enrico,
> 
> These tests are failing on Windows.  They're new tests so not really a regression, but do you have any idea what might be wrong?  Basically, when the test runs, the help po is displaying the full output of "help expression".  But strangely, if I go into lldb and run "help po" there, it's correct and the output would pass the test.
> 
> So something is different about running through the public api or running help inside of lldb
> 

This doesn’t seem to have much to do with “the public API” since it’s a lame plain old command-line test

Honestly, no, I am not sure what would be special about this on Windows. The only thing I can think of is that maybe - for whatever reason - the test suite is running against an older LLDB, but that seems fairly unlikely to go unnoticed, now does it?

Your best bet may be to put a sleep() call in the test case to give yourself a chance to attach with a debugger - and then step through the “help” code as things unfold

> On Mon, Mar 14, 2016 at 6:47 PM Enrico Granata via lldb-commits <lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>> wrote:
> Author: enrico
> Date: Mon Mar 14 20:43:00 2016
> New Revision: 263520
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=263520&view=rev <http://llvm.org/viewvc/llvm-project?rev=263520&view=rev>
> Log:
> Add some test coverage for the changes in alias help
> 
> 
> Modified:
>     lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py
> 
> Modified: lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py?rev=263520&r1=263519&r2=263520&view=diff <http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py?rev=263520&r1=263519&r2=263520&view=diff>
> ==============================================================================
> --- lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py (original)
> +++ lldb/trunk/packages/Python/lldbsuite/test/help/TestHelp.py Mon Mar 14 20:43:00 2016
> @@ -167,6 +167,24 @@ class HelpCommandTestCase(TestBase):
>                          'variable +--'])
> 
>      @no_debug_info_test
> +    def test_help_po_hides_options(self):
> +        """Test that 'help po' does not show all the options for expression"""
> +        self.expect("help po",
> +            substrs = ['--show-all-children', '--object-description'], matching=False)
> +
> +    @no_debug_info_test
> +    def test_help_run_hides_options(self):
> +        """Test that 'help run' does not show all the options for process launch"""
> +        self.expect("help run",
> +            substrs = ['--arch', '--environment'], matching=False)
> +
> +    @no_debug_info_test
> +    def test_help_next_shows_options(self):
> +        """Test that 'help next' shows all the options for thread step-over"""
> +        self.expect("help next",
> +            substrs = ['--python-class','--run-mode'], matching=True)
> +
> +    @no_debug_info_test
>      def test_help_provides_alternatives(self):
>          """Test that help on commands that don't exist provides information on additional help avenues"""
>          self.expect("help thisisnotadebuggercommand",
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org <mailto:lldb-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160318/7b4807b8/attachment-0001.html>