[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32

[Cameron via lldb-commits]

cameron314 added a comment.

Since it works without my patch, you're probably right about it being related to the UNICODE define. All the other changes are completely removed from that part of the code. But I still don't see how it could affect that.

Here's the script I use to run cmake:

  setlocal 
  set PATH=%ProgramFiles%\Ninja;%ProgramFiles(x86)%\CMake\bin;%SYSTEMROOT%\system32;%SYSTEMROOT%;%SWIGDIR% 
  call "%VS140COMNTOOLS%\vsvars32.bat" 
  mkdir VS2015Debug 
  cd VS2015Debug 
  cmake -G "Ninja" -DLLVM_BUILD_EXAMPLES:BOOL=false -DPYTHON_HOME="C:\Python35" -DLLDB_DISABLE_PYTHON:BOOL=false -DLLDB_TEST_COMPILER=%cd%\bin\clang.exe -DCMAKE_BUILD_TYPE=Debug .. 
  cd .. 
  mkdir VS2015Release 
  cd VS2015Release 
  cmake -G "Ninja" -DLLVM_BUILD_EXAMPLES:BOOL=false -DPYTHON_HOME="C:\Python35" -DLLDB_DISABLE_PYTHON:BOOL=false -DLLDB_TEST_COMPILER=%cd%\bin\clang.exe -DCMAKE_BUILD_TYPE=Release .. 
  cd .. 
  endlocal

This is with VS2015 update 1. And it's already the x86 version, the patch has diverged significantly from what we have locally (which is based on a snapshot from several weeks ago) so I've been using the tip as-is :-)

I'm trying a fresh Debug build from scratch (deleting and re-creating the cmake build folder). I'll report back when it's done.


http://reviews.llvm.org/D17107