[Lldb-commits] [PATCH] D18005: Fixed ValueObject::GetExpressionPath() for paths including anonymous struct/union

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 9 11:56:55 PST 2016

jingham added a subscriber: jingham.
jingham added a comment.

The source change looks fine, but Greg's the owner of this code so I'll let him say yes for sure.

But don't call the test case "ExpressionPath".  The expression parser is different from frame variable.  I understand that your intent was "the expression you feed to frame variable" but since we have an "expression" command, and the expressions you feed to it are different from those you feed to "frame variable" overloading the word is only going to cause confusion.



More information about the lldb-commits mailing list