[Lldb-commits] [PATCH] D17970: Implement ObjectFilePECOFF::GetEntryPointAddress.

[Greg Clayton via lldb-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

ObjectFilePECOFF::GetEntryPointAddress() is not implemented correctly. See inlined comments.


================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:823
@@ +822,3 @@
+
+    return m_coff_header_opt.entry;
+}
----------------
You will need to convert the file address "m_coff_header_opt.entry" into a section offset address before returning this. See ObjectFileELF::GetEntryPointAddress() for info on how to do this correctly and also how to cache the entry address in case it is asked for multiple time. ObjectFileELF has an instance variable "Address m_entry_point_address;" that it will populate once and lazily and return it is we have resolved the address, otherwise it will resolve the file address using the section list.


http://reviews.llvm.org/D17970