[Lldb-commits] [PATCH] D17724: Replace getopt with llvm::cl in lldb driver
Jim Ingham via lldb-commits
lldb-commits at lists.llvm.org
Thu Mar 3 12:33:28 PST 2016
> On Mar 2, 2016, at 10:18 AM, Greg Clayton <clayborg at gmail.com> wrote:
> So this is nice that you cleaned up this one place where we can use LLVM's option parsing stuff, but it now makes the driver inconsistent with the rest of LLDB. It also makes it so you have to link some LLVM .a files into the lldb command line driver which we didn't have before. If we are going to make a change away from getopt_long(), I would rather change everything over. Otherwise we have our command line that behaves one way, and all of our command interpreter commands behaving another. And if we use option parsing from the driver, I would rather have the one consistent way that we handle options be exported through the lldb::SB API with something like:
There's another reason why we want to expose defining command options & argument at the SB API layer. Right now all the Python based commands have to do their own argument & help parsing, and so those commands are distinctly "second-class citizens." They don't show up right in help & apropos, and they don't do argument completion. So if anybody has some spare time to take a whack at this, that would be really great.
More information about the lldb-commits