[Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Tue Mar 1 10:32:31 PST 2016
On Tue, Mar 1, 2016 at 10:10 AM Greg Clayton <clayborg at gmail.com> wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
> One general comment is the use of "auto". Although it makes the code
> shorter, it does make it quite a bit less readable. I will leave the
> decision to you since this is your code, but in general I think this is
> where auto is less than it is cracked up to be.
I agree with you in principle, but I used it here because these types are
really ugly because they're unique pointers of types whose names are
already long. I could typedef them to UP or something, but they wouldn't
be able to go in lldb-forward.h because they shouldnt be publicly exposed.
I'll think about it some more and decide what to do.
Have to run right now, will respond to the rest of your comments later.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits