[Lldb-commits] [PATCH] D17716: Add complex and aggregate with vector types return value test cases
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Mon Feb 29 06:35:12 PST 2016
labath added a subscriber: labath.
labath requested changes to this revision.
labath added a reviewer: labath.
labath added a comment.
This revision now requires changes to proceed.
I agree with Tamas here. Your previous patch also added a some tests here, which were breaking on some configurations (linux+gcc in this case). It's not a good idea no XFAIL the whole test just because of the added checks (which can be tested completely independently of the original test). If you don't want to refactor the existing checks, then please at least put the new checks (and the ones I just reverted) into a test of it's own.
More information about the lldb-commits