[Lldb-commits] [PATCH] D17708: Add/Improve complex, vector, aggregate types handling for SysV ARM (hard/soft) ABI.

Tamas Berghammer via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 29 03:54:59 PST 2016

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

Looks good (it would be nice if we can split GetReturnValueObjectImpl to multiple function as it starts to become pretty big and hard to read but I don't think we shouldn't do it as part of this CL)

Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:586-588
@@ -576,3 +585,5 @@
+            if (is_complex && float_count == 2)
+            {
(nit): It can be an "else if"

Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:599-601
@@ -579,3 +598,5 @@
+            }
+            else
             // not handled yet
             return return_valobj_sp;
(nit); Indentation


More information about the lldb-commits mailing list