[Lldb-commits] [PATCH] D17635: Continue after process exit

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 26 16:07:43 PST 2016


jingham added a comment.

I don't think you can manipulate the public run lock in PrivateResume like this.  PrivateResume gets run in a bunch of places (like calling functions) that are way below the level the public run lock.  You probably need to catch errors from PrivateResume in Resume and release the lock there.

That's a little ugly, but it is good to have PrivateResume return an accurate error, so I think putting the check there is right.


http://reviews.llvm.org/D17635





More information about the lldb-commits mailing list