[Lldb-commits] [PATCH] D17363: Add SymbolFilePDB with basic support for line tables.
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 26 15:26:13 PST 2016
> On Feb 26, 2016, at 3:22 PM, Zachary Turner <zturner at google.com> wrote:
> On Fri, Feb 26, 2016 at 3:16 PM Greg Clayton <clayborg at gmail.com> wrote:
> > On Feb 26, 2016, at 2:49 PM, Zachary Turner <zturner at google.com> wrote:
> > I'm coming back around to this now. What happens if check_inlines is False, but the FileSpec is a header file like <vector>. You said "If check_inlines is false, make sure file_spec matches". But if file_spec is a header file, it's never going to match anything. Should I simply expect that the API is not called in this way?
> It can be called, but you should only match on compile units whose files match "vector" as the basename.
> Ahh, so I don't return each compile unit that matches the file_spec, but rather each CompileUnit where the compile unit OR one of the support files matches the file_spec.
Yes. Think of what the user is going to want if they type:
(lldb) b vector:123
This should find all files that match vector and set a breakpoint on line 123 of _all_ of them.
More information about the lldb-commits