[Lldb-commits] [PATCH] D17650: Fix TestInlines.py on Windows

[Adrian McCarthy via lldb-commits]

amccarth created this revision.
amccarth added reviewers: zturner, spyffe.
amccarth added a subscriber: lldb-commits.

The inlining semantics for C and C++ are different, which affects the test's expectation of the number of times the function should appear in the binary.  In the case of this test, C semantics means there should be three instances of inner_inline, while C++ semantics means there should be only two.

On Windows, clang uses C++ inline semantics even for C code, and there doesn't seem to be a combination of compiler flags to avoid this.

So, for consistency, I've recast the test to use C++ everywhere.  Since the test resided under lang/c, it seemed appropriate to move it to lang/cpp.

This does not address the other XFAIL for this test on Linux/gcc.  See https://llvm.org/bugs/show_bug.cgi?id=26710

http://reviews.llvm.org/D17650

Files:
  packages/Python/lldbsuite/test/lang/c/inlines/Makefile
  packages/Python/lldbsuite/test/lang/c/inlines/TestInlines.py
  packages/Python/lldbsuite/test/lang/c/inlines/inlines.c
  packages/Python/lldbsuite/test/lang/c/inlines/inlines.h
  packages/Python/lldbsuite/test/lang/cpp/inlines/Makefile
  packages/Python/lldbsuite/test/lang/cpp/inlines/TestInlines.py
  packages/Python/lldbsuite/test/lang/cpp/inlines/inlines.cpp
  packages/Python/lldbsuite/test/lang/cpp/inlines/inlines.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17650.49208.patch
Type: text/x-patch
Size: 8171 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160226/1123347b/attachment-0001.bin>