[Lldb-commits] [PATCH] D17650: Fix TestInlines.py on Windows
Adrian McCarthy via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 26 11:03:45 PST 2016
amccarth created this revision.
amccarth added reviewers: zturner, spyffe.
amccarth added a subscriber: lldb-commits.
The inlining semantics for C and C++ are different, which affects the test's expectation of the number of times the function should appear in the binary. In the case of this test, C semantics means there should be three instances of inner_inline, while C++ semantics means there should be only two.
On Windows, clang uses C++ inline semantics even for C code, and there doesn't seem to be a combination of compiler flags to avoid this.
So, for consistency, I've recast the test to use C++ everywhere. Since the test resided under lang/c, it seemed appropriate to move it to lang/cpp.
This does not address the other XFAIL for this test on Linux/gcc. See https://llvm.org/bugs/show_bug.cgi?id=26710
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8171 bytes
Desc: not available
More information about the lldb-commits