[Lldb-commits] [PATCH] D17465: Get register context for the 32-bit process in a WoW64 process minidump.

[Zachary Turner via lldb-commits]

zturner accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: source/Plugins/Process/Windows/Common/NtStructures.h:18
@@ +17,3 @@
+// only about the position of the TlsSlots.
+struct TEB64
+{
----------------
Just as a general tip for future reference, you can get better definitions of these structures in WinDbg.  In this case, for example, `dt ntdll!_TEB64` gives a fairly comprehensive definition of `_TEB64`.  The offset of `TlsSlots` matches up with what you have here too, which at least shows it's correct.

================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:238-240
@@ +237,5 @@
+
+                    // NOTE:  We don't currently use the TEB for anything else.  If we need it in
+                    // the future, the 32-bit TEB is located according to the address stored in the
+                    // first slot of the 64-bit TEB (wow64teb.Reserved1[0]).
+                }
----------------
Interesting, according to WinDbg's definition of `_TEB64`, the TEB has this field:


```
+0x180c WowTebOffset     : Int4B
```

Not sure what the difference is between this and `wow64teb.Reserved1[0]` (if there is one at all), but maybe we'll need this in the future (or maybe it's not what it sounds like)


http://reviews.llvm.org/D17465