[Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 24 07:56:31 PST 2016

Sorry that comment was a mistake.  When you uploaded the most recent diff,
did you generate the diff against your first patch?  Or against tip of
trunk?  I think you may have generated it against your first patch, but
Phabricator gets confused and shows the wrong thing in that case.

It should be fine for me to download it and apply this way, but it makes it
harder to review.  So in the future always generated all versions of your
diff against the same base.

On Wed, Feb 24, 2016 at 1:48 AM Petr Hons <pe.hons at gmail.com> wrote:

> Honsik added a comment.
> The testsuite passed the same way as master, but no UNEXPECTED SUCCESS.
> Please fix the miss spelling directly.
> Thanks.
> ================
> Comment at: source/Host/common/FileSpec.cpp:517
> @@ -511,2 +516,2 @@
>      // If full is false, then if either directory is empty, then we match
> on
> ----------------
> I don't know what check you mean. bool case_sensitive is the check here.
> http://reviews.llvm.org/D17492
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160224/b1b07ba4/attachment.html>

More information about the lldb-commits mailing list