[Lldb-commits] [PATCH] D17545: Fix PythonDataObjectsTests for python 2

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 23 08:47:16 PST 2016

labath added inline comments.

Comment at: unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:212
@@ -211,3 +211,2 @@
     PythonBytes python_bytes(PyRefType::Owned, py_bytes);
-    EXPECT_EQ(PyObjectType::Bytes, python_bytes.GetObjectType());
zturner wrote:
> Seems like this check is still valid?
Not on python 2, I get "string" there. We can't have checks on line 212 and 216 both be true, so I assumed "string" is intended. Note that I have simply moved this check into the python-3 branch.


More information about the lldb-commits mailing list