[Lldb-commits] [PATCH] D17521: Update website for building and testing on Windows

[Adrian McCarthy via lldb-commits]

amccarth added a comment.

Could you post the patch with full context? It's easier to see the changes in context.

The information looks right.  It's nice to see all the build-Python-yourself stuff simplified away.


================
Comment at: www/build.html:63
@@ -64,1 +62,3 @@
+                versions of Python can be made to work by compiling your own distribution from source,
+                but this workflow is unsupported and you are own your own.
               </li>
----------------
typo: "on your own" not "own your own"

================
Comment at: www/build.html:67
@@ -66,2 +66,3 @@
               <li><a href="http://gnuwin32.sourceforge.net/">GnuWin32</a></li>
-              <li><a href="http://www.swig.org/download.html">SWIG for Windows</a></li>
+              <li><a href="http://www.swig.org/download.html">SWIG for Windows (version 3+)</a></li>
+            </ul>
----------------
Wasn't there a particular version (like 3.0.5) that had a specific bug?  I seem to recall you needed something older or something very recent.

================
Comment at: www/test.html:67
@@ -63,4 +66,3 @@
             <p>
-              To dump additional information to <tt>stdout</tt> about how the test harness is driving LLDB, run
-              <tt>dotest.py</tt> with the <tt>-t</tt> flag. Many more options that are available. To see a list of all of them, run:
+              Many more options that are available. To see a list of all of them, run:
             </p>
----------------
delete "that"

================
Comment at: www/test.html:139
@@ +138,3 @@
+              On Windows, it is strongly recommended to use <a href="https://github.com/Microsoft/PTVS/releases">Python Tools for Visual Studio</a>
+              for debugging test failures.  It can seamlessly step between native and managed code, which is very helpful when you need to step
+              through the test itself, and then into the LLDB code that backs the operations the test is performing.  A quick guide to getting
----------------
Did you mean "managed" here?  Would it be clearer to say you can step between the test script and the native LLDB code?

"Seamlessly" is a stretch. ;-)

================
Comment at: www/test.html:160
@@ +159,3 @@
+                    <li>Go to Tools -> Options -> Python Tools -> Environment Options</li>
+                    <li>Click Add Environment, and enter <code>Python 3.5 Debug</code> for the name.  Fill out the values correctly.</li>
+                  </ul>
----------------
It might be useful to give examples here.  For one thing, it might not be obvious at this point that the Path and Windows Path fields should point do the `_d` version of the Python executable.


http://reviews.llvm.org/D17521