[Lldb-commits] [PATCH] D17465: Get register context for the 32-bit process in a WoW64 process minidump.

[Zachary Turner via lldb-commits]

zturner added inline comments.

================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:192
@@ +191,3 @@
+// only about the position of the TlsSlots.
+struct TEB64 {
+    ULONG64 Reserved1[12];
----------------
I think this structure should go in a different header file in Process/Windows/Common.  Maybe it could be called `NtStructures.h` or something like that.

================
Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:236-237
@@ +235,4 @@
+                    {
+                        // Slot 1 of the thread-local storage in the 64-bit TEB points to a structure
+                        // that includes the 32-bit CONTEXT (after a ULONG).
+                        const size_t addr = wow64teb.TlsSlots[1];
----------------
Are the other fields of this structure known what they mean?


http://reviews.llvm.org/D17465