[Lldb-commits] [lldb] r261356 - Fix Clang-tidy modernize-use-nullptr and modernize-use-default warnings in some files in source/Commands; other minor fixes.
Eugene Zelenko via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 19 13:03:28 PST 2016
On Fri, Feb 19, 2016 at 12:33 PM, Jim Ingham <jingham at apple.com> wrote:
> Please don't make this sort of change. With the code as originally written, I can set a breakpoint on the returns "true" or "false" case separately, and stop there if I am doing that experiment, whereas your change makes that impossible. Neither one is particularly harder to read than the other, but your version is significantly harder to debug.
I this particular case it'w much easier to debug at point of usage.
Actually multiple comparisons could be replaced with strchr().
More information about the lldb-commits