[Lldb-commits] [PATCH] D17455: Remove expectedFailureFreeBSD decorator

[Ed Maste via lldb-commits]

emaste added inline comments.

================
Comment at: packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py:26-27
@@ -25,5 +25,4 @@
     @skipIfFreeBSD # llvm.org/pr24691 skipping to avoid crashing the test runner
-    @expectedFailureFreeBSD('llvm.org/pr19011') # Newer Clang omits C1 complete object constructor
-    @expectedFailureFreeBSD('llvm.org/pr24691') # we hit an assertion in clang
+    @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr19011 Newer Clang omits C1 complete object constructor')
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
     @skipIfTargetAndroid() # skipping to avoid crashing the test runner
----------------
Yes - I left two of them because they're different PRs, but didn't notice that the 2nd was a duplicate of the `@skipIfFreeBSD`. Thanks for catching it.

================
Comment at: packages/Python/lldbsuite/test/functionalities/attach_resume/TestAttachResume.py:22
@@ -21,3 +21,3 @@
     @skipIfRemote
-    @expectedFailureFreeBSD('llvm.org/pr19310')
+    @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr19310')
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
----------------
thanks, not sure how that slipped through.


http://reviews.llvm.org/D17455