[Lldb-commits] [PATCH] D17455: Remove expectedFailureFreeBSD decorator

[Zachary Turner via lldb-commits]

zturner added inline comments.

================
Comment at: packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py:26-27
@@ -25,4 +25,4 @@
     @skipIfFreeBSD # llvm.org/pr24691 skipping to avoid crashing the test runner
-    @expectedFailureFreeBSD('llvm.org/pr19011') # Newer Clang omits C1 complete object constructor
-    @expectedFailureFreeBSD('llvm.org/pr24691') # we hit an assertion in clang
+    @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr19011 Newer Clang omits C1 complete object constructor')
+    @expectedFailureAll(oslist=['freebsd'], bugnumber='llvm.org/pr24691 we hit an assertion in clang')
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr21765")
----------------
We have `skipIfFreeBSD` and then 2 instances of `expectedFailureFreeBSD`, the second of which is a duplicate of the skip.  Maybe you could just delete the second line.

================
Comment at: packages/Python/lldbsuite/test/functionalities/attach_resume/TestAttachResume.py:22
@@ -21,3 +21,3 @@
     @skipIfRemote
-    @expectedFailureFreeBSD('llvm.org/pr19310')
+    @expectedFailureAll(oslist=['freebsd', bugnumber='llvm.org/pr19310')
     @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24778")
----------------
Missing closing `]` after `'freebsd'`


http://reviews.llvm.org/D17455