[Lldb-commits] [PATCH] D17167: Fix bug with register values byte order in expression evaluation
Sean Callanan via lldb-commits
lldb-commits at lists.llvm.org
Thu Feb 18 17:11:19 PST 2016
spyffe requested changes to this revision.
spyffe added a comment.
This revision now requires changes to proceed.
Looks fine to me, but let's put in an assertion to make sure our assumptions in making this change are not violated.
Comment at: source/Expression/Materializer.cpp:1282
@@ +1281,3 @@
+ map.WriteScalarToMemory(load_addr, scalar, scalar.GetByteSize(), write_error);
Let's put an //lldbassert// in here to make sure `scalar.GetByteSize() == register_data.GetByteSize()`.
I know it ought to be, but I'm a little bit wary of that code.
More information about the lldb-commits