[Lldb-commits] [PATCH] D17395: Refactor GetSoftwareBreakpointTrapOpcode

[Aidan Dodds via lldb-commits]

ADodds created this revision.
ADodds added reviewers: clayborg, emaste, ted, zturner, jasonmolenda.
ADodds added a subscriber: lldb-commits.
ADodds set the repository for this revision to rL LLVM.
Herald added a subscriber: emaste.

This patch aims to reduce the code duplication among all of the platforms in GetSoftwareBreakpointTrapOpcode.  Common code has been pushed into the Platform base class, and only special case platform code has been left in the derived platforms.

When remote debugging it can be the case that your current host platform will be queried for the trap opcode to use on the target, which currently lead to different results depending on the host lldb is running on.  With this patch, platforms have a more unified view of trap opcodes for targets.

Some platforms however have specific/special case requirements so I should not have effected their functionality.

Do others think this is a usefull refactor, or have suggestions/feedback?

Repository:
  rL LLVM

http://reviews.llvm.org/D17395

Files:
  include/lldb/Target/Platform.h
  source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
  source/Plugins/Platform/Linux/PlatformLinux.cpp
  source/Plugins/Platform/Linux/PlatformLinux.h
  source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp
  source/Plugins/Platform/NetBSD/PlatformNetBSD.h
  source/Plugins/Platform/Windows/PlatformWindows.cpp
  source/Plugins/Platform/Windows/PlatformWindows.h
  source/Target/Platform.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17395.48324.patch
Type: text/x-patch
Size: 17783 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160218/f8ec452c/attachment.bin>