[Lldb-commits] [PATCH] D17182: Adjust for Python-3.

[Siva Chandra via lldb-commits]

sivachandra added inline comments.

================
Comment at: source/API/liblldb.exports:4
@@ -3,1 +3,2 @@
 init_lld*
+PyInit__lld*
----------------
labath wrote:
> zturner wrote:
> > I don't really know what the syntax of this file is, but the symbol is called `PyInit__lldb`, not `PyInit__lld`.  Is this still correct?  Does it matter that you're exporting both the Python 2 and the Python 3 symbol in both versions even when they're not defined?
> This just restricts the exported symbols to the ones matching the wildcards, so I don't think it matters that both are present. 
> OTOH, unless we know the reason why the `b` has to be omitted from the wildcard, then I suggest you add it.
I just followed the existing "convention". Works without the "*" as well, so removed it according to the suggestion.

================
Comment at: source/API/liblldb.exports:4
@@ -3,1 +3,2 @@
 init_lld*
+PyInit__lld*
----------------
sivachandra wrote:
> labath wrote:
> > zturner wrote:
> > > I don't really know what the syntax of this file is, but the symbol is called `PyInit__lldb`, not `PyInit__lld`.  Is this still correct?  Does it matter that you're exporting both the Python 2 and the Python 3 symbol in both versions even when they're not defined?
> > This just restricts the exported symbols to the ones matching the wildcards, so I don't think it matters that both are present. 
> > OTOH, unless we know the reason why the `b` has to be omitted from the wildcard, then I suggest you add it.
> I just followed the existing "convention". Works without the "*" as well, so removed it according to the suggestion.
zturner: The listing here does not say what *should* be exported, but that a symbol should be exported only if matches one of these regexes.


http://reviews.llvm.org/D17182