[Lldb-commits] [PATCH] D17182: Adjust for Python-3.
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 12 04:16:29 PST 2016
labath accepted this revision.
This revision is now accepted and ready to land.
Comment at: scripts/Python/modules/readline/readline.cpp:55
@@ -39,1 +54,3 @@
+#if PY_VERSION_HEX >= 0x03000000
+simple_readline(FILE *stdin, FILE *stdout, const char *prompt)
existing code uses `PY_MAJOR_VERSION >= 3` (which also looks much nicer), so let's be consistent.
Comment at: source/API/liblldb.exports:4
@@ -3,1 +3,2 @@
> I don't really know what the syntax of this file is, but the symbol is called `PyInit__lldb`, not `PyInit__lld`. Is this still correct? Does it matter that you're exporting both the Python 2 and the Python 3 symbol in both versions even when they're not defined?
This just restricts the exported symbols to the ones matching the wildcards, so I don't think it matters that both are present.
OTOH, unless we know the reason why the `b` has to be omitted from the wildcard, then I suggest you add it.
More information about the lldb-commits