[Lldb-commits] [PATCH] D17107: [lldb] Unicode support on Win32
Cameron via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 10 17:21:12 PST 2016
cameron314 added a comment.
Thanks for all the feedback! I'll look into it in detail tomorrow.
Perhaps it would make more sense if I clarified where I'm coming from with this patch -- we use LLDB on Windows (with a custom backend) where I work, and wanted to be able to run a program with a non-ASCII path (and similarly place breakpoints in such files, etc.). So, I tried to make //minimally invasive// changes across the codebase in order to accomplish this, using the existing LLVM support functions as much as possible. This is why the changes are not entirely consistent as a whole -- I preferred consistency with the surrounding code (e.g. error handling and buffer allocation) over global consistency.
More information about the lldb-commits