[Lldb-commits] [PATCH] D17106: Fix SocketTest on Windows

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 10 14:58:05 PST 2016

zturner created this revision.
zturner added a reviewer: vharron.
zturner added a subscriber: lldb-commits.

Hi Vince,

I'm not sure why the #if _WIN32 check is even in there to begin with, but I tested on Windows 7 and Windows 10 and in both cases the output is that of the non _WIN32 path.  Were you seeing this other value in practice?

In any case, this patch fixes it for me, so I'm curious to see how this came about.



Index: unittests/Host/SocketAddressTest.cpp
--- unittests/Host/SocketAddressTest.cpp
+++ unittests/Host/SocketAddressTest.cpp
@@ -33,11 +33,7 @@
     ASSERT_EQ (0, sa.GetPort ());
     ASSERT_TRUE (sa.SetToLocalhost (AF_INET6, 1139));
-#ifdef _WIN32
-    ASSERT_STREQ ("0:0:0:0:0:0:0:1", sa.GetIPAddress ().c_str ());
     ASSERT_STREQ ("::1", sa.GetIPAddress ().c_str ());
     ASSERT_EQ (1139, sa.GetPort ());

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17106.47537.patch
Type: text/x-patch
Size: 502 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160210/f7a5cc53/attachment.bin>

More information about the lldb-commits mailing list