[Lldb-commits] [PATCH] D16938: A number of improvements to decorator conditionals

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 8 03:08:33 PST 2016

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good, after applying one fix.

Comment at: packages/Python/lldbsuite/test/decorators.py:148
@@ +147,3 @@
+        skip_for_triple = _match_decorator_property(triple, lldb.DBG.GetSelectedPlatform().GetTriple())
+        skip_for_remote = _match_decorator_property(remote, remote == (lldb.remote_platform is not None))
The `actual` value should be simply `lldb.remote_platform is not None`. When remote_platform is None, we are local, when it is not None, we are remote.

Btw, since this flag can only have three values (None, True, False), the _match_decorator property dance is not really necessary. Although, I guess it won't hurt either...


More information about the lldb-commits mailing list