[Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Sun Feb 7 22:06:08 PST 2016


tfiala accepted this revision.
tfiala added a comment.
This revision is now accepted and ready to land.

LGTM with the change you suggested above.  I tried that and it worked on OS X.  The change itself looked fine as well.


================
Comment at: packages/Python/lldbsuite/test/decorators.py:170-171
@@ -169,2 +169,4 @@
                 reason_str = "{} unconditionally"
+            if bugnumber is not None:
+                reason_str = reason_str + " [" + bugnumber + "]"
         return reason_str
----------------
zturner wrote:
> Can you try changing this to this and see what happens:
> 
>     if bugnumber is not None and not six.callable(bugnumber):
>         reason_str = reason_str + " [" + str(bugnumber) + "]"
> 
Yep, that fixed the errors.


http://reviews.llvm.org/D16936





More information about the lldb-commits mailing list