[Lldb-commits] [PATCH] D16936: Remove expectedFailureWindows decorator

Fri Feb 5 14:49:26 PST 2016

zturner created this revision.
zturner added reviewers: tfiala, labath.
zturner added a subscriber: lldb-commits.

Putting this up for review not because you guys are interested in windows, but just because I'm hoping to do this with more of the decorators.  Assuming nobody has any issues with this, I will do the rest without review.

    expectedFailureWindows is equivalent to using the general
    expectedFailureAll decorator with oslist="windows".  Additionally,
    by moving towards these common decorators we can solve the issue
    of having to support decorators that can be called with or without
    arguments.  Once all decorators are always called with arguments,
    and this is enforced by design (because you can't specify the condition
    you're decorating for without passing an argument) the implementation
    of the decorators can become much simpler, which in turn will lead to
    less difficulties when moving from `unittest2` to `unittest` as well as supporting
    class level decorators for skip as well as xfail on all decorators.

http://reviews.llvm.org/D16936

Files:
  packages/Python/lldbsuite/test/api/multiple-debuggers/TestMultipleDebuggers.py
  packages/Python/lldbsuite/test/benchmarks/disassembly/TestDisassembly.py
  packages/Python/lldbsuite/test/benchmarks/disassembly/TestXcode41Vs42GDBDisassembly.py
  packages/Python/lldbsuite/test/benchmarks/expression/TestExpressionCmd.py
  packages/Python/lldbsuite/test/benchmarks/expression/TestRepeatedExprs.py
  packages/Python/lldbsuite/test/benchmarks/frame_variable/TestFrameVariableResponse.py
  packages/Python/lldbsuite/test/benchmarks/startup/TestStartupDelays.py
  packages/Python/lldbsuite/test/benchmarks/stepping/TestSteppingSpeed.py
  packages/Python/lldbsuite/test/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py
  packages/Python/lldbsuite/test/decorators.py
  packages/Python/lldbsuite/test/driver/batch_mode/TestBatchMode.py
  packages/Python/lldbsuite/test/expression_command/call-function/TestCallStdStringFunction.py
  packages/Python/lldbsuite/test/expression_command/call-function/TestCallStopAndContinue.py
  packages/Python/lldbsuite/test/expression_command/call-function/TestCallUserDefinedFunction.py
  packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
  packages/Python/lldbsuite/test/expression_command/expr-in-syscall/TestExpressionInSyscall.py
  packages/Python/lldbsuite/test/expression_command/formatters/TestFormatters.py
  packages/Python/lldbsuite/test/expression_command/issue_11588/Test11588.py
  packages/Python/lldbsuite/test/expression_command/persistent_types/TestNestedPersistentTypes.py
  packages/Python/lldbsuite/test/expression_command/persistent_types/TestPersistentTypes.py
  packages/Python/lldbsuite/test/expression_command/radar_9531204/TestPrintfAfterUp.py
  packages/Python/lldbsuite/test/expression_command/radar_9673664/TestExprHelpExamples.py
  packages/Python/lldbsuite/test/expression_command/test/TestExprs.py
  packages/Python/lldbsuite/test/expression_command/test/TestExprs2.py
  packages/Python/lldbsuite/test/expression_command/timeout/TestCallWithTimeout.py
  packages/Python/lldbsuite/test/functionalities/archives/TestBSDArchives.py
  packages/Python/lldbsuite/test/functionalities/attach_resume/TestAttachResume.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_locations/TestBreakpointLocations.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/cpp/TestCPPBreakpointLocations.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/cpp_exception/TestCPPExceptionBreakpoint.py
  packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
  packages/Python/lldbsuite/test/functionalities/conditional_break/TestConditionalBreak.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-disabling/TestDataFormatterDisabling.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-skip-summary/TestDataFormatterSkipSummary.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/dump_dynamic/TestDumpDynamic.py
  packages/Python/lldbsuite/test/functionalities/data-formatter/stringprinter/TestStringPrinter.py
  packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py
  packages/Python/lldbsuite/test/functionalities/disassembly/TestDisassembleBreakpoint.py
  packages/Python/lldbsuite/test/functionalities/dynamic_value_child_count/TestDynamicValueChildCount.py
  packages/Python/lldbsuite/test/functionalities/embedded_interpreter/TestConvenienceVariables.py
  packages/Python/lldbsuite/test/functionalities/expr-doesnt-deadlock/TestExprDoesntBlock.py
  packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py
  packages/Python/lldbsuite/test/functionalities/inferior-crashing/TestInferiorCrashing.py
  packages/Python/lldbsuite/test/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferior.py
  packages/Python/lldbsuite/test/functionalities/launch_with_shellexpand/TestLaunchWithShellExpand.py
  packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py
  packages/Python/lldbsuite/test/functionalities/plugins/commands/TestPluginCommands.py
  packages/Python/lldbsuite/test/functionalities/return-value/TestReturnValue.py
  packages/Python/lldbsuite/test/functionalities/thread/crash_during_step/TestCrashDuringStep.py
  packages/Python/lldbsuite/test/functionalities/thread/create_during_step/TestCreateDuringStep.py
  packages/Python/lldbsuite/test/functionalities/thread/exit_during_break/TestExitDuringBreak.py
  packages/Python/lldbsuite/test/functionalities/thread/multi_break/TestMultipleBreakpoints.py
  packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py
  packages/Python/lldbsuite/test/functionalities/thread/step_out/TestThreadStepOut.py
  packages/Python/lldbsuite/test/functionalities/thread/thread_specific_break/TestThreadSpecificBreakpoint.py
  packages/Python/lldbsuite/test/functionalities/value_md5_crash/TestValueMD5Crash.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocation/TestWatchLocation.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchpoint/TestMyFirstWatchpoint.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/multiple_threads/TestWatchpointMultipleThreads.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/step_over_watchpoint/TestStepOverWatchpoint.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/TestWatchpointCommands.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandLLDB.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/command/TestWatchpointCommandPython.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_commands/condition/TestWatchpointConditionCmd.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_events/TestWatchpointEvents.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py
  packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_set_command/TestWatchLocationWithWatchSet.py
  packages/Python/lldbsuite/test/lang/c/anonymous/TestAnonymous.py
  packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py
  packages/Python/lldbsuite/test/lang/c/function_types/TestFunctionTypes.py
  packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py
  packages/Python/lldbsuite/test/lang/c/modules/TestCModules.py
  packages/Python/lldbsuite/test/lang/c/set_values/TestSetValues.py
  packages/Python/lldbsuite/test/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.py
  packages/Python/lldbsuite/test/lang/c/stepping/TestStepAndBreakpoints.py
  packages/Python/lldbsuite/test/lang/c/strings/TestCStrings.py
  packages/Python/lldbsuite/test/lang/c/struct_types/TestStructTypes.py
  packages/Python/lldbsuite/test/lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py
  packages/Python/lldbsuite/test/lang/cpp/call-function/TestCallCPPFunction.py
  packages/Python/lldbsuite/test/lang/cpp/chained-calls/TestCppChainedCalls.py
  packages/Python/lldbsuite/test/lang/cpp/class_static/TestStaticVariables.py
  packages/Python/lldbsuite/test/lang/cpp/dynamic-value/TestDynamicValue.py
  packages/Python/lldbsuite/test/lang/cpp/exceptions/TestCPPExceptionBreakpoints.py
  packages/Python/lldbsuite/test/lang/cpp/global_operators/TestCppGlobalOperators.py
  packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py
  packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespaceLookup.py
  packages/Python/lldbsuite/test/lang/cpp/overloaded-functions/TestOverloadedFunctions.py
  packages/Python/lldbsuite/test/lang/cpp/rdar12991846/TestRdar12991846.py
  packages/Python/lldbsuite/test/lang/cpp/rvalue-references/TestRvalueReferences.py
  packages/Python/lldbsuite/test/lang/cpp/scope/TestCppScope.py
  packages/Python/lldbsuite/test/lang/cpp/static_members/TestCPPStaticMembers.py
  packages/Python/lldbsuite/test/lang/cpp/static_methods/TestCPPStaticMethods.py
  packages/Python/lldbsuite/test/lang/cpp/this/TestCPPThis.py
  packages/Python/lldbsuite/test/python_api/disassemble-raw-data/TestDisassemble_VST1_64.py
  packages/Python/lldbsuite/test/python_api/event/TestEvents.py
  packages/Python/lldbsuite/test/python_api/frame/TestFrames.py
  packages/Python/lldbsuite/test/python_api/hello_world/TestHelloWorld.py
  packages/Python/lldbsuite/test/python_api/lldbutil/iter/TestRegistersIterator.py
  packages/Python/lldbsuite/test/python_api/lldbutil/process/TestPrintStackTraces.py
  packages/Python/lldbsuite/test/python_api/sbvalue_persist/TestSBValuePersist.py
  packages/Python/lldbsuite/test/python_api/symbol-context/TestSymbolContext.py
  packages/Python/lldbsuite/test/python_api/target/TestTargetAPI.py
  packages/Python/lldbsuite/test/python_api/thread/TestThreadAPI.py
  packages/Python/lldbsuite/test/python_api/value/TestValueAPI.py
  packages/Python/lldbsuite/test/python_api/value/change_values/TestChangeValueAPI.py
  packages/Python/lldbsuite/test/python_api/watchpoint/TestSetWatchpoint.py
  packages/Python/lldbsuite/test/python_api/watchpoint/TestWatchpointIgnoreCount.py
  packages/Python/lldbsuite/test/python_api/watchpoint/TestWatchpointIter.py
  packages/Python/lldbsuite/test/python_api/watchpoint/watchlocation/TestSetWatchlocation.py
  packages/Python/lldbsuite/test/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py
  packages/Python/lldbsuite/test/settings/quoting/TestQuoting.py
  packages/Python/lldbsuite/test/tools/lldb-mi/TestMiExit.py
  packages/Python/lldbsuite/test/tools/lldb-mi/TestMiGdbSetShow.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16936.47052.patch
Type: text/x-patch
Size: 121225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160205/7662ae7c/attachment-0001.bin>