[Lldb-commits] [PATCH] D16830: Move some android platform functions to lldbplatformutil

[Pavel Labath via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Seems to be working after applying the fixes below.

I was considering whether this shouldn't be moved to an even more platform-specific file (say `androidutil.py` or something), but I'll leave that up to you...


================
Comment at: packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py:63
@@ -62,3 +62,3 @@
     def check_stop_reason(self):
-        match_result = matchAndroid(api_levels=list(range(1, 16+1)))(self)
-        if match_result is not None:
+        match_result = lldbplatformutil.match_android_device(self.getArchitecture(), api_levels=list(range(1, 16+1)))
+        if match_result == lldbplatformutil.AndroidMatchResult.Matched:
----------------
valid_api_levels=...

================
Comment at: packages/Python/lldbsuite/test/lldbplatformutil.py:38
@@ +37,3 @@
+    full_cmd = ["adb"] + device_id_args + cmd
+    p = subprocess.Popen(full_cmd, stdout=PIPE, stderr=PIPE)
+    stdout, stderr = p.communicate()
----------------
subprocess.PIPE


http://reviews.llvm.org/D16830