[Lldb-commits] [PATCH] D16736: Always write the session log file in UTF-8

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Sun Jan 31 12:07:10 PST 2016


tfiala added a comment.

In http://reviews.llvm.org/D16736#340302, @tfiala wrote:

> In any event, the right fix here probably is to have displays of matched/expected text for known-to-be binary data *not* try to print results in the expect-string-match code since these are just going to have no way of being valid.


i.e. a test fix.  I think we still want to keep the unicode decode guard in, as it could easily be something printing binary-based data like we had here, but the culprit under this is basically the method the test is using to verify binary data.


http://reviews.llvm.org/D16736





More information about the lldb-commits mailing list