[Lldb-commits] [PATCH] D16736: Always write the session log file in UTF-8

[Todd Fiala via lldb-commits]

tfiala added a comment.

In http://reviews.llvm.org/D16736#339925, @tfiala wrote:

> In http://reviews.llvm.org/D16736#339889, @zturner wrote:
>
> > Hmm, that almost looks to me like it's finding a real bug.  Which it
> >  probably is, because higher up the callstack it's reading the response of a
> >  memory send.  I'm guessing that the response includes non-printable
> >  characters (raw memory data) that wasn't being written before but was being
> >  silently ignored, and now it's giving an error.
> >
> > Can you try passing errors='replace' to encoded_file.open()?  Then open the
> >  log file and see what's in it.
>
>
> Yep, I can give that a try.  It'll end up being later (not at a computer now) but I'll give it a shot.


I'm going to have a look at trying this modification now.


http://reviews.llvm.org/D16736