[Lldb-commits] [PATCH] D16736: Always write the session log file in UTF-8

[Todd Fiala via lldb-commits]

tfiala added a comment.

The only test I see fail with this is:
TestGDBRemoteMemoryRead.py:




ERROR: test_memory_read_dwarf (TestGDBRemoteMemoryRead.MemoryReadTestCase)
--------------------------------------------------------------------------

Traceback (most recent call last):

  File "/Users/tfiala/lldb/tot/git-svn/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2289, in dwarf_test_method
    return attrvalue(self)
  File "/Users/tfiala/lldb/tot/git-svn/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGDBRemoteMemoryRead.py", line 37, in test_memory_read
    self.match("process plugin packet send x%x,%x" % (pc, size), ["response:", memory])
  File "/Users/tfiala/lldb/tot/git-svn/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2615, in match
    self.runCmd(str, msg=msg, trace = (True if trace else False), check = not error)
  File "/Users/tfiala/lldb/tot/git-svn/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2591, in runCmd
    print(self.res.GetError(), file=sbuf)
  File "/Users/tfiala/lldb/tot/git-svn/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 267, in __exit__
    print(self.getvalue(), file=self.session)
  File "/Users/tfiala/lldb/tot/git-svn/lldb/packages/Python/lldbsuite/support/encoded_file.py", line 32, in impl
    s = s.decode(encoding)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)

UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 90: invalid start byte


http://reviews.llvm.org/D16736