[Lldb-commits] [PATCH] D16741: Make many of the skip decorators use common code

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 29 16:09:52 PST 2016


zturner created this revision.
zturner added reviewers: labath, tberghammer, tfiala.
zturner added a subscriber: lldb-commits.

Trying to reduce the complexity of all our decorators, I decided to make most of them use `skipTestIfFn`.  Unfortunately there's some issues with my patch.  I'm not really an expert with all these decorators and multiple levels of decorating, but something about that is causing some issues.  

For example, I get this now when running the test suite:

UNEXPECTED SUCCESS: test_Hc_then_Csignal_signals_correct_thread_launch_debugserver_dwarf (tools\lldb-server\TestLldbGdbServer.py)
UNEXPECTED SUCCESS: test_with_attach_to_process_with_id_api_dwarf (python_api\hello_world\TestHelloWorld.py)
UNEXPECTED SUCCESS: test_with_attach_to_process_with_name_api_dwarf (python_api\hello_world\TestHelloWorld.py)

But the tests are still failing.  Would someone mind helping me figure out what's wrong here?

http://reviews.llvm.org/D16741

Files:
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_in_delayslot/TestAvoidBreakpointInDelaySlot.py
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16741.46449.patch
Type: text/x-patch
Size: 14887 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160130/e34fc08d/attachment-0001.bin>


More information about the lldb-commits mailing list