[Lldb-commits] [PATCH] D16722: Remove Timer::Initialize routine

[Pavel Labath via lldb-commits]

labath created this revision.
labath added reviewers: clayborg, zturner, tberghammer.
labath added a subscriber: lldb-commits.

I've run into an issue when running unit tests, where the underlying problem turned out to be
that we were creating Timer objects (through several layers of indirection) without calling
Timer::Initialize. Since Timer's thread-local storage was not properly initialized, we were
overwriting gtest's own thread-local storage, causing test failures.

Instead of requiring that every test calls Timer::Initialize(), I remove the function altogether:
The thread-local storage can be initialized on-demand, and the g_file variable initialized to
stdout and never changed, so I have simply removed it.

http://reviews.llvm.org/D16722

Files:
  include/lldb/Core/Timer.h
  source/Core/Timer.cpp
  source/Initialization/SystemInitializerCommon.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16722.46380.patch
Type: text/x-patch
Size: 3556 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160129/84067e5c/attachment-0001.bin>