[Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

[Zachary Turner via lldb-commits]

zturner added inline comments.

================
Comment at: include/lldb/Core/RangeMap.h:1230
@@ -1229,3 +1229,3 @@
                 typename Collection::const_iterator pos;
-                for(pos = m_entries.begin(); pos != m_entries.end(); pos++)
+                for (pos = m_entries.begin(); pos != m_entries.end(); pos++)
                 {
----------------
If you're making cleanup changes anyway, how about a ranged based for.

================
Comment at: include/lldb/Symbol/Symtab.h:84
@@ -83,3 +83,3 @@
             Symbol *    FindSymbolContainingFileAddress (lldb::addr_t file_addr);
-            void        ForEachSymbolContainingFileAddresss (lldb::addr_t file_addr, std::function <bool(Symbol *)> const &callback);
+            void        ForEachSymbolContainingFileAddress (lldb::addr_t file_addr, std::function <bool(Symbol *)> const &callback);
             size_t      FindFunctionSymbols (const ConstString &name, uint32_t name_type_mask, SymbolContextList& sc_list);
----------------
Did you use clang-format?  If you had this would have a return type on a new line (although obviously you don't want that here since it woudl be inconsistent with the rest of the file).

I guess you would need to clang-format it, then don't take the change to this line.  (Which maybe is exactly what you did, just checking)

================
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:183
@@ +182,3 @@
+    }
+    return lldb::eSymbolTypeInvalid;
+}
----------------
Instead of returning `eSymbolTypeInvalid` here, how about `eSymbolTypeData`?  If you look in `llvm/Support/COFF.h` all of the non function types are data.


http://reviews.llvm.org/D16563