[Lldb-commits] [PATCH] D16563: Set symbol types for function symbols loaded from PE/COFF

[Adrian McCarthy via lldb-commits]

amccarth created this revision.
amccarth added reviewers: zturner, clayborg.
amccarth added a subscriber: lldb-commits.

This fixes the regression of several tests on Windows after rL258621.

The root problem is that ObjectFilePECOFF was not setting type information for the symbols, and the new CL rejects symbols without type information, breaking functionality like `thread step-over`.

The fix sets the type information for functions (and creates a TODO for other types).

Along the way, I fixed some typos and formatting that made the code I was debugging harder to understand.

In the long run, we should consider replacing most of ObjectFilePECOFF with the COFF parsing code from LLVM.

http://reviews.llvm.org/D16563

Files:
  include/lldb/Core/RangeMap.h
  include/lldb/Symbol/Symtab.h
  source/Core/Module.cpp
  source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
  source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
  source/Symbol/Symtab.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16563.45925.patch
Type: text/x-patch
Size: 7492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160126/ef1615e1/attachment.bin>