[Lldb-commits] [PATCH] D16397: [LLDB] Consider only valid symbols while resolving by address

[Zachary Turner via lldb-commits]

Also various other formatting problems.  Please run clang-format in the
future.

Steps to running clang-format
1. Compile it with "ninja clang-format"
2. Add your bin directory to PATH
3. Stage your changes with git add as you normally do
4. Run "git clang-format"

On Mon, Jan 25, 2016 at 11:51 AM Adrian McCarthy via lldb-commits <
lldb-commits at lists.llvm.org> wrote:

> amccarth added a subscriber: amccarth.
> amccarth added a comment.
>
> This patch  broke approximately 10 tests on Windows, mostly related to
> thread step-over, thread step-out, etc.  We probably  need to fix something
> in PECOFF::GetSymTab that's causing all the symbols to be rejected.  I'll
> look into it more.
>
>
> ================
> Comment at: lldb/trunk/source/Symbol/Symtab.cpp:1077
> @@ -1076,1 +1076,3 @@
>  void
> +Symtab::ForEachSymbolContainingFileAddresss (addr_t file_addr,
> std::function <bool(Symbol *)> const &callback)
> +{
> ----------------
> Addresss has too many `s`s.
>
> ================
> Comment at: lldb/trunk/source/Symbol/Symtab.cpp:1092
> @@ +1091,3 @@
> +        if (!callback(SymbolAtIndex(all_addr_indexes[i])))
> +        break;
> +    }
> ----------------
> Indentation problem.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D16397
>
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160125/0269ea9f/attachment.html>