[Lldb-commits] [PATCH] D16423: test suite: fix exception if --platform-name is specified that doesn't start with "remote-"

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 22 11:37:18 PST 2016


tfiala added inline comments.

================
Comment at: packages/Python/lldbsuite/test/dosep.py:1145
@@ -1144,1 +1144,3 @@
+        else:
+            target = None
 
----------------
labath wrote:
> I think this should be `target = platform_name`, so that you can still match the ios-simulator platform below (the point of the regex was to remove the "remote-" prefix, I believe), but I guess it doesn't really matter, as we are getting rid of the whole function anyway...
Yep, I agree on both counts:
1. I'll change,
2. It won't matter if/when Ed has a look at this since I don't think we'll need to call out expected timeouts this way.

I'll adjust and submit the adjustment after I test it.

Thanks!


http://reviews.llvm.org/D16423





More information about the lldb-commits mailing list