[Lldb-commits] [lldb] r258429 - Add CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab to ensure that (nearly) all the symbols have sizes.

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 21 12:58:13 PST 2016


Author: amccarth
Date: Thu Jan 21 14:58:12 2016
New Revision: 258429

URL: http://llvm.org/viewvc/llvm-project?rev=258429&view=rev
Log:
Add CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab to ensure that (nearly) all the symbols have sizes.

This fixes the `thread step-over` regression exposed by http://reviews.llvm.org/D16186 , which depends on the symbols having actual sizes.  Nine tests on Windows had started failing as a result.  They all work again with this fix.

Differential Revision: http://reviews.llvm.org/D16415

Modified:
    lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp?rev=258429&r1=258428&r2=258429&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Thu Jan 21 14:58:12 2016
@@ -649,6 +649,7 @@ ObjectFilePECOFF::GetSymtab()
                     symbols[i].SetDebug(true);
                 }
             }
+            m_symtab_ap->CalculateSymbolSizes();
         }
     }
     return m_symtab_ap.get();




More information about the lldb-commits mailing list