[Lldb-commits] [PATCH] D16334: Fix TestSignedTypes.py by removing a bogus step-over

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 21 11:54:47 PST 2016


zturner added a comment.

Right, but I don't agree in this case that "different" has to mean "we
discourage the use of reduced test cases".  I have a hard time imagining a
scenario where not having reduced test cases is an advantage.  It's also
easy to explain to people.  "Write reduced test cases".  It's easy to
understand.  Moreso than "Reduced test cases are good, but not always
because fuzziness, but we can't really put into words exactly what amount
of fuzziness we want, or what it should look like, so I guess anything goes

- don't ask don't tell".

If we want fuzziness, we should do fuzz testing.  Feature tests and
regression tests should be reduced.  The whole reason the tests in
lldb/tests were written is because people were testing a specific feature
or bugfix.  I don't see a reason to add fuzziness to this kind of test.
All it does is pollute failure logs.  Fuzziness is better tested by fuzz
tests.


http://reviews.llvm.org/D16334





More information about the lldb-commits mailing list