[Lldb-commits] [PATCH] D16423: test suite: fix exception if --platform-name is specified that doesn't start with "remote-"

Todd Fiala via lldb-commits lldb-commits at lists.llvm.org
Thu Jan 21 11:50:46 PST 2016


tfiala created this revision.
tfiala added a reviewer: labath.
tfiala added a subscriber: lldb-commits.

As would happen if the test suite was given "--platform-name iso-simulator".

Also removes the expected timeouts for Darwin as these are now handled by reruns.

http://reviews.llvm.org/D16423

Files:
  packages/Python/lldbsuite/test/dosep.py

Index: packages/Python/lldbsuite/test/dosep.py
===================================================================
--- packages/Python/lldbsuite/test/dosep.py
+++ packages/Python/lldbsuite/test/dosep.py
@@ -1135,29 +1135,24 @@
 def getExpectedTimeouts(platform_name):
     # returns a set of test filenames that might timeout
     # are we running against a remote target?
-    host = sys.platform
     if platform_name is None:
         target = sys.platform
     else:
         m = re.search(r'remote-(\w+)', platform_name)
-        target = m.group(1)
+        if m:
+            target = m.group(1)
+        else:
+            target = None
 
     expected_timeout = set()
 
-    if target.startswith("freebsd"):
+    if target is not None and target.startswith("freebsd"):
         expected_timeout |= {
             "TestBreakpointConditions.py",
             "TestChangeProcessGroup.py",
             "TestValueObjectRecursion.py",
             "TestWatchpointConditionAPI.py",
         }
-    elif target.startswith("darwin"):
-        expected_timeout |= {
-            # times out on MBP Retina, Mid 2012
-            "TestThreadSpecificBreakpoint.py",
-            "TestExitDuringStep.py",
-            "TestIntegerTypesExpr.py",
-        }
     return expected_timeout
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16423.45575.patch
Type: text/x-patch
Size: 1285 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160121/8beb172e/attachment-0001.bin>


More information about the lldb-commits mailing list