[Lldb-commits] [PATCH] D16322: Enable test log collection from remote debug servers

[Pavel Labath via lldb-commits]

labath added inline comments.

================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1385-1386
@@ +1384,4 @@
+            # This is executed on a best-effort basis. If the file is not there, so be it.
+            lldb.remote_platform.Get(lldb.SBFileSpec("server.log"),
+                    lldb.SBFileSpec(self.getLogBasenameForCurrentTest()+"-server.log"))
+
----------------
tfiala wrote:
> It might be nice to get some kind of output (perhaps in verbose mode?) if we're expecting the server.log to be there but we fail to retrieve it.  (Just a warning).  Does lldb.remote_platform.Get() already do that on a failure?
It's not really clear when are we expecting it. A user might choose to enable logging on the remote system, or he may choose not to. Both are valid options, and right now we don't tell the client which one of them is happening. So, unless we introduce another option `--enable-server-logging` or something, the client has no way of knowing whether server logging is active.

Perhaps I could just rephrase the comment to better explain the "best-effort" part?


http://reviews.llvm.org/D16322