[Lldb-commits] [PATCH] D16293: [cmake] Make dependencies of lldb libraries private

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 20 04:43:15 PST 2016


labath added a comment.

Zachary, could you take a look at this please. I'd like to squeeze this into 3.8 if it is working..

> At some point lldb-argdumper is planned to be reworked just slightly so it had no dependencies on the lldb core. (That would have avoided this I suspect.)


It would, although I don't see a problem with the argdumper re-using the json parser from lldb (even though the parser is not the public interface of liblldb). The whole LINKER_SUPPORTS_GROUPS thing could be beautified a bit (I might do that afterwards), but otherwise, the whole thing seems reasonable to me.


http://reviews.llvm.org/D16293





More information about the lldb-commits mailing list