[Lldb-commits] [PATCH] D14111: Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

[Bhushan Attarde via lldb-commits]

bhushan added a comment.

In http://reviews.llvm.org/D14111#330305, @spyffe wrote:

> That looks fine to me as far as it goes, but it doesn't cover other places where $ is used in function names, e.g. the name of the expression itself, and classes it's placed in.  Could you have a look at ExpressionSourceCode.cpp and see if there is anything there that needs a $ as well?


The other function names in ExpressionSourceCode.cpp e.g. `$__lldb_expr` does not require to be prefixed with an additional underscore like `_$__lldb_expr`.
This is because these names get mangled by the compiler to something like `_Z12$__lldb_exprPv`, so they does not start with "$" and hence not marked as ‘temporary’ symbols.

The additional `_` prefix is only needed for "$__lldb_valid_pointer_check" since this name does not get mangled by compiler (may be because it has C Language linkage).


Repository:
  rL LLVM

http://reviews.llvm.org/D14111