[Lldb-commits] [PATCH] D16334: Fix TestSignedTypes.py by removing a bogus step-over

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 19 16:22:27 PST 2016


jingham added a subscriber: jingham.
jingham added a comment.

I agree with Zachary.  Just because a test found a bug that wasn't essential to the test doesn't mean we should "fix" the test by silencing the part of the test that uncovered the bug.

This test puts a breakpoint on a 'puts("")' statement and steps over it.  All the variables should still be available at that point.  So this is a real bug.

If really want to get this particular test working, then it would be okay to add another test that uncovers the same bug but doesn't test the actual values, xfail that and then delete the step here.


http://reviews.llvm.org/D16334





More information about the lldb-commits mailing list