[Lldb-commits] [PATCH] D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

Bhushan Attarde via lldb-commits lldb-commits at lists.llvm.org
Tue Jan 19 03:08:33 PST 2016


bhushan updated the summary for this revision.
bhushan updated this revision to Diff 45237.
bhushan added a comment.

Addressed review comments.
Instead of adding new decorator, this patch modifies existing `skipUnlessArch` to detect the type of the "archs" variable and do the things according to the type.
This handles regular expressions as well.

The python test file then uses this decorator as `@skipUnlessArch(archs=re.compile('mips*'))` to skip any architectures other than mips.


Repository:
  rL LLVM

http://reviews.llvm.org/D16049

Files:
  include/lldb/API/SBInstruction.h
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_in_delayslot/Makefile
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_in_delayslot/TestAvoidBreakpointInDelaySlot.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_in_delayslot/main.c
  packages/Python/lldbsuite/test/lldbtest.py
  scripts/interface/SBInstruction.i
  source/API/SBInstruction.cpp
  source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D16049.45237.patch
Type: text/x-patch
Size: 8483 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160119/43c57f25/attachment.bin>


More information about the lldb-commits mailing list