[Lldb-commits] [PATCH] D16107: Fix for Bug 25338
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Mon Jan 18 08:06:45 PST 2016
labath added a comment.
I think this looks *much* nicer than the previous version.
I personally would replace the `std::function` dance with something simpler such as `bool use_memory_fallback`, but I guess that's a matter of taste.
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.h:13
@@ -12,2 +12,3 @@
+#include <functional>
// C Includes
----------------
Please put this right before <vector>
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.h:284
@@ -281,3 +283,3 @@
GetProgramHeaderInfo(ProgramHeaderColl &program_headers,
- lldb_private::DataExtractor &data,
+ const SetDataFunction set_data,
const elf::ELFHeader &header);
----------------
const non-reference arguments are somewhat pointless. Did you forget a reference here?
================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.h:307
@@ -304,3 +306,3 @@
GetSectionHeaderInfo(SectionHeaderColl §ion_headers,
- lldb_private::DataExtractor &data,
+ const SetDataFunction set_data,
const elf::ELFHeader &header,
----------------
same here
http://reviews.llvm.org/D16107
More information about the lldb-commits
mailing list