[Lldb-commits] [PATCH] D16237: Fixes to ensure TestLogging.py tests work with Python 3.5 as well as 2.7.

[Zachary Turner via lldb-commits]

looks good

On Fri, Jan 15, 2016 at 12:44 PM Adrian McCarthy <amccarth at google.com>
wrote:

> amccarth updated this revision to Diff 45023.
> amccarth added a comment.
>
> Used the more explicit assertion methods.
>
>
> http://reviews.llvm.org/D16237
>
> Files:
>   packages/Python/lldbsuite/test/logging/TestLogging.py
>
> Index: packages/Python/lldbsuite/test/logging/TestLogging.py
> ===================================================================
> --- packages/Python/lldbsuite/test/logging/TestLogging.py
> +++ packages/Python/lldbsuite/test/logging/TestLogging.py
> @@ -61,7 +61,7 @@
>          f.close ()
>          os.remove (log_file)
>
> -        self.assertTrue(log_lines > 0, "Something was written to the log
> file.")
> +        self.assertGreater(len(log_lines), 0, "Something was written to
> the log file.")
>
>      # Check that lldb truncates its log files
>      @no_debug_info_test
> @@ -83,7 +83,7 @@
>              contents = f.read ()
>
>          # check that it got removed
> -        self.assertTrue(string.find(contents, "bacon") == -1)
> +        self.assertEquals(contents.find("bacon"), -1)
>
>      # Check that lldb can append to a log file
>      @no_debug_info_test
> @@ -104,4 +104,4 @@
>              contents = f.read ()
>
>          # check that it is still there
> -        self.assertTrue(string.find(contents, "bacon") == 0)
> +        self.assertEquals(contents.find("bacon"), 0)
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20160115/fd57a962/attachment.html>