[Lldb-commits] [PATCH] D16049: [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Thu Jan 14 08:10:43 PST 2016
zturner added a comment.
In http://reviews.llvm.org/D16049#326634, @labath wrote:
> In http://reviews.llvm.org/D16049#326631, @bhushan wrote:
> > Hi Zachary,
> > If we use @skipIf then the list would require to contain all possible MIPS variations and the list will grow long.
> > for ex: @skipIf(archs=not_in(['mips32','mips32r2', 'mips32r3', 'mips64','mips64r2', 'mips64r3', 'mips64r6' ......]))
> > @skipUnlessMips covers all these possible values using regular expression matching.
> I agree with Zachary that we have too many decorators and we shouldn't be expanding their number, it's simply not sustainable. I see two options here:
> - add a `getMipsArchitectures()` function and then write `archs=not_in(getMipsArchitectures())`
> - add a `not_regex()` function and write `archs=not_regex('mips.*')` How does that sound?
Another idea is to change the implementation of `not_in` to do the same thing that `check_list_or_lambda` does. i.e. Return a lambda that iterates each item of the argument and uses substring match instead of exact match. This way `@skipIf(archs=not_in('mips'))` would actually work.
Any of these 3 options sounds fine though.
More information about the lldb-commits